Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37329 )
Change subject: sb/amd/cimx/sb800: add C bootblock southbridge initialization
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37329/2/src/southbridge/amd/cimx/sb...
File src/southbridge/amd/cimx/sb800/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37329/2/src/southbridge/amd/cimx/sb...
PS2, Line 129: bootblock_southbridge_init();
It does lots of things: PMIOA programming, ALINK configuration, SPI fast speed configuration, legacy […]
Ok. Sounds like serial port behind LPC would not require the call to be made.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie81198f5034a84d319ee7143aa032433f82be254
Gerrit-Change-Number: 37329
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Dec 2019 16:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment