Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40836 )
Change subject: mb/google/dedede: Read DRAM part number from CBI
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40836/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/romstage.c:
https://review.coreboot.org/c/coreboot/+/40836/2/src/mainboard/google/dedede...
PS2, Line 42: strlen(part_num_store)
Just think why do we need to return a fixed size which normally is bigger then size of part number i […]
And refer to [1], it is processed by strncpy and MIN(sizeof(dimm->module_part_number), module_part_number_size). If we do sizeof here then no optimization copy there but a duplicated info?
[1] https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/hea...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40836
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40780a35e04efb279591e9db179cb86b5e907c0d
Gerrit-Change-Number: 40836
Gerrit-PatchSet: 2
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Apr 2020 23:58:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment