Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35349 )
Change subject: drivers/intel/fsp2_0: Allocate cfg_region_size for UPD ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35349/2/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/35349/2/src/drivers/intel/fsp2_0/si... PS2, Line 43: (hdr->cfg_region_size)
Passing NULL is legal, but the cfg when it is NULL should be coming from this region specifically. […]
Right. Passing NULL into FSP is fine and legal. But this region size being 0 kind of breaks the rest of the assumptions here. sizeof(FSPS_UPD) being 0 is definitely an interesting case. I believe we can handle it when the need comes up?
https://review.coreboot.org/c/coreboot/+/35349/2/src/drivers/intel/fsp2_0/si... PS2, Line 48: printk(BIOS_ERR, "FSP error: more UPD specified than allowed by header cfg_region_size\n");
Everything's undefined at this point since we don't have matching object sizes to start from.
Exactly.