[coreboot-gerrit] Change in coreboot[master]: google/krane: Add panel boe TV101WUM-NL6 support

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32512 )

Change subject: google/krane: Add panel boe TV101WUM-NL6 support
......................................................................

Patch Set 16:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32512/16/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/c/coreboot/+/32512/16/src/mainboard/google/kukui... 
PS16, Line 363: PERIPHERAL_EN13
I think most kukui family will use same GPIOs for backlight. Maybe move to the common file?

https://review.coreboot.org/c/coreboot/+/32512/16/src/mainboard/google/kukui... 
PS16, Line 371: 	if (board_id() < 2) {
              : 		/* board from p1 */
              : 		gpio_output(GPIO(LCM_RST), 0);
              : 		udelay(100);
              : 		gpio_output(GPIO(LCM_RST), 1);
              : 		mdelay(20);
              : 	} else {
              : 		/* board from p2 */
you don't need this since there's no krane with id < 2.