Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45598 )
Change subject: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG@7 PS4, Line 7: mb/google/volteer/variants/eldrid: fine-tune USB2 Eye Diagram mb/google/volteer: Improve Eldrid Port 1 USB2 Eye Diagram
https://review.coreboot.org/c/coreboot/+/45598/4//COMMIT_MSG@9 PS4, Line 9: needs : to be overridde. needs to be overridden
https://review.coreboot.org/c/coreboot/+/45598/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45598/4/src/mainboard/google/voltee... PS4, Line 51: usb2 suggestion: These settings improve the USB2 Port1 eye diagram