22 Jan
2020
22 Jan
'20
8:04 a.m.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38505 )
Change subject: mb/intel/tglrvp: Enable SATA ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38505/3/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38505/3/src/mainboard/intel/tglrvp/... PS3, Line 47: : register "SataEnable" = "1"
do you still need this config as i could see below code, you have relied on .cb on/off options […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/38505
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f35682982a6c06522e58b0bbd7162ff02c37f32
Gerrit-Change-Number: 38505
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Subrata Banik subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 22 Jan 2020 08:04:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment