[coreboot-gerrit] [M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API

[Jérémy Compostella (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Julius Werner, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.

Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email )

Change subject: lib: Refactor ux_locales_get_text API
......................................................................

Patch Set 5:

(2 comments)

File src/lib/ux_locales.c:

https://review.coreboot.org/c/coreboot/+/86283/comment/5c64cd8f_a3ca3404?usp... :
PS5, Line 32: 	enum ux_locale_msg locale_msg_id;
Is locale_msg_id used ?

Also, I would recommend the initialization to be written as follow. It will bind the data to the right without any assumption on the order.
```
} ux_locale_msg_list[] = {
    [UX_LOCALE_MSG_MEMORY_TRAINING] = { UX_MEMORY_TRAINING_DESC, UX_MEMORY_TRAINING_MSG },
};
```

https://review.coreboot.org/c/coreboot/+/86283/comment/2098acd3_eadd2907?usp... :
PS5, Line 213: 	switch (msg_id) {
Could we have a `MAX_UX_LOCALE` to avoid having to add every single enum in this switch case statement?