12 Jun
2020
12 Jun
'20
10:04 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42319 )
Change subject: util/rockchip: port make_idb.py to python3 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42319/1/util/rockchip/make_idb.py File util/rockchip/make_idb.py:
https://review.coreboot.org/c/coreboot/+/42319/1/util/rockchip/make_idb.py@4... PS1, Line 49: pages = (sectors - 1) / PAGE_ALIGN + 1 I think all these divisions need to use // (I'm surprised 2to3 doesn't do that automatically).
--
To view, visit https://review.coreboot.org/c/coreboot/+/42319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e399c491ab07cd3e7fda24231cf3f7611b341e3
Gerrit-Change-Number: 42319
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Jun 2020 22:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment