Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48665 )
Change subject: soc/amd/picasso: Correctly populate the PCI interrupt line register
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48665/1/src/soc/amd/picasso/pcie_gp...
File src/soc/amd/picasso/pcie_gpp.c:
https://review.coreboot.org/c/coreboot/+/48665/1/src/soc/amd/picasso/pcie_gp...
PS1, Line 44: static struct pirq_struct pirq_data[] = {
I guess duplicating this table could be avoided by moving the PCI routing code to amd_pci_util.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48665
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5d4d8f613c8d0fa9b43cefa804824681c3410d6
Gerrit-Change-Number: 48665
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 05 Jan 2021 21:38:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment