Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@7
PS7, Line 7: mb/google/deltaur: Support to Enable GbE on variant
Please make it a statement by adding a verb (in imperative mood).
Done
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@9
PS7, Line 9: -Configure devicetree for enabling GbE on variant
Please remove the tab, and add a space after the “bullet”. […]
Done
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@14
PS7, Line 14:
Please remove the blank line.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c36b132546049e3e775585c41164072f4ece73e
Gerrit-Change-Number: 40001
Gerrit-PatchSet: 8
Gerrit-Owner: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 06 Apr 2020 18:28:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment