Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47809 )
Change subject: sb/intel/lynxpoint: Reorder defines for PCI IDs ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47809/4/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/47809/4/src/southbridge/intel/lynxp... PS4, Line 229: PCI_DEVICE_ID_INTEL_LPT_H_DESKTOP_SATA_IDE, /* 0x8c00 */ : PCI_DEVICE_ID_INTEL_LPT_H_MOBILE_SATA_IDE, /* 0x8c01 */ : PCI_DEVICE_ID_INTEL_LPT_H_DESKTOP_SATA_AHCI, /* 0x8c02 */ : PCI_DEVICE_ID_INTEL_LPT_H_MOBILE_SATA_AHCI, /* 0x8c03 */ : PCI_DEVICE_ID_INTEL_LPT_H_DESKTOP_SATA_RAID_1, /* 0x8c04 */ : PCI_DEVICE_ID_INTEL_LPT_H_MOBILE_SATA_RAID_1, /* 0x8c05 */ : PCI_DEVICE_ID_INTEL_LPT_H_DESKTOP_SATA_RAID_2, /* 0x8c06 */ : PCI_DEVICE_ID_INTEL_LPT_H_MOBILE_SATA_RAID_2, /* 0x8c07 */ : PCI_DEVICE_ID_INTEL_LPT_H_DESKTOP_SATA_IDE_P45, /* 0x8c08 */ : PCI_DEVICE_ID_INTEL_LPT_H_MOBILE_SATA_IDE_P45, /* 0x8c09 */ : PCI_DEVICE_ID_INTEL_LPT_H_DESKTOP_SATA_RAID_3, /* 0x8c0e */ : PCI_DEVICE_ID_INTEL_LPT_H_MOBILE_SATA_RAID_3, /* 0x8c0f */ This is *not* an improvement.