Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39390 )
Change subject: cbfstool: Build vboot library
......................................................................
Patch Set 5:
I noticed that cbfstool builds vboot hostlib, while futility builds vboot futil, and there're no common *.c files for these 2 vboot targets, so I can't see how vboot will be built twice. Am I missing something?
Futility depends on FWLIB and UTILLIB which, while separate lists of files, contain a lot of overlap with HOSTLIB files. So in the end you'll still save a lot of duplication.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc826896d895f53d69ea559a88f75672c2ec3146
Gerrit-Change-Number: 39390
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Mar 2020 22:13:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment