Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35619 )
Change subject: cpu/intel/common: Move intel_ht_sibling() to common folder ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35619/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35619/5//COMMIT_MSG@7 PS5, Line 7: cpu/intel/common: Move intel_ht_sibling() to common folder
does this really need to be moved? why not include ht/sibling?
It's only build on model_f2x and model_f3x.
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/common... File src/cpu/intel/common/common.h:
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/common... PS5, Line 33: bool
Please include the header that defines this type.
Done
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/hypert... File src/cpu/intel/common/hyperthreading.c:
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/hypert... PS5, Line 29: 28
Do we not have these bits defined somewhere?
Added definition
https://review.coreboot.org/c/coreboot/+/35619/5/src/cpu/intel/common/hypert... PS5, Line 35: < 1
The only valid value to hit this condition. […]
Done