Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42436 )
Change subject: mb/google/volteer: Override power limits with SKU-specific limits ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42436/2/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/42436/2/src/soc/intel/tigerlake/chi... PS2, Line 25: #define POWER_LIMITS_4_CORE 0 : #define POWER_LIMITS_2_CORE 1
we may want to use more descriptive naming here, specially since […]
Ack
https://review.coreboot.org/c/coreboot/+/42436/2/src/soc/intel/tigerlake/sys... File src/soc/intel/tigerlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/42436/2/src/soc/intel/tigerlake/sys... PS2, Line 80: switch (sa_pci_id) {
we'll need to include PCI_DEVICE_ID_INTEL_TGL_ID_Y at some point.
Sure, I just haven't seen anything yet. LMK if you do 😊 I also don't see 9A10 (TGL-Y) called out in the stepping ID guide...