EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33379 )
Change subject: soc/intel: Provide SPD manufacturer ID and module type to SMBIOS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33379/1/src/soc/intel/apollolake/meminit_uti...
File src/soc/intel/apollolake/meminit_util_apl.c:
https://review.coreboot.org/#/c/33379/1/src/soc/intel/apollolake/meminit_uti...
PS1, Line 98: 0);
I don't believe there are APL designs with actual DIMM and SPD, they should all be LPDDR.
I think most of chrome project use the on-board ram with SPD file which we can read from ROM directly. Is Sarien the first one use the switchable RAM? If with SPD file we can easily do it within coreboot. With dynamic ram will be a duplicate work in FSP and coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id673e08aa6e3dad196009c3c21a3dda2f40c9e42
Gerrit-Change-Number: 33379
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Jun 2019 17:25:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Keith Short
keithshort@chromium.org
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment