Attention is currently required from: Arthur Heymans, Varshit Pandya.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76510?usp=email )
Change subject: vendorcode/amd: Add opensil code ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Instead of copying all of opensil into the coreboot repo, could we make it a submodule? […]
Agreed - My thought is to create a repo at coreboot.org based on your changes. We can use both your repo and the opensil/opensil github repos as remotes and just pull to different branches. From there, we can cherry-pick changes from either, or even commit new patches as needed by coreboot.
We'd then use that repo as the submodule. I was thinking we'd place it in src/vendorcode/amd/opensil/genoa/openSIL so that the coreboot Kconfigs and makefiles for it live in vc/amd/opensil/genoa and could be maintained at coreboot.org instead of in the opensil repo itself.
I got preliminary buy in from the coreboot team at AMD, so I'm going to push some patches that will handle a submodule in that location before I actually create the submodule.