Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32263 )
Change subject: google/kukui: Include LCD module identifier (LCM ID) into SKU ID ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c... PS5, Line 28: KUKUI_
nit: btw, this is a file-local #define in a kukui-specific file, the KUKUI_ prefix is a bit superflu […]
Added because we have FLAPJACK doing totally different things; but yes let's try to remove them.
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c... PS5, Line 33: static const int voltages_default[] = {
You'd need to pass the size in another parameter as well, of course. […]
Since all AP ADCs should have 12 levels I think it's no harm to make it a const instead of ARRAY_SIZE. Please see my next version.