EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47912 )
Change subject: mb/google/zork/var/vliboz: Add LTE_RST power sequence
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47912/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/variant.c:
https://review.coreboot.org/c/coreboot/+/47912/1/src/mainboard/google/zork/v...
PS1, Line 42: GPIO_89
SG, will discuss with HW and do some experiments. […]
It worked if we add pull-down for it:)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f0a35a905d711dd8d17dea2ae82a8dfa1fa05ed
Gerrit-Change-Number: 47912
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Dec 2020 11:52:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment