Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37215 )
Change subject: pci_ids: Update Intel Lewisburg SMBUS PCI ID ......................................................................
Patch Set 5:
(8 comments)
Patch Set 5: Code-Review+1
Patch Set 1:
Though I will believe to rename to LBG will be better than LWB as that will match with Linux kernel.
I'd suggest using LBG if it's the official name
If everyone agrees, I can rename LWB to LBG. Or we will get this patch in, and do the rename in a sweep at a later time.
https://review.coreboot.org/c/coreboot/+/37215/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37215/4//COMMIT_MSG@7 PS4, Line 7: PCIe ID
PCI ID
Done
https://review.coreboot.org/c/coreboot/+/37215/4/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37215/4/src/include/device/pci_ids.... PS4, Line 3326:
Remove the extra tab here.
Done
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 2720: #define PCI_DEVICE_ID_INTEL_LWB_C621 0xa1c1
Please see https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 2804: PCI_DEVICE_ID_INTEL_C620_LPC 0xA1C1
This ID already exist - PCI_DEVICE_ID_INTEL_LWB_C621
Done
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 3045: PCI_DEVICE_ID_INTEL_C620_PMC 0xa1a1
duplicates PCI_DEVICE_ID_INTEL_LWB_PMC
Ack
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 3176: PCI_DEVICE_ID_INTEL_C620_SPI
duplicates PCI_DEVICE_ID_INTEL_LWB_SPI
Ack
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 3336: PCI_DEVICE_ID_INTEL_C620_SMBUS
duplicates PCI_DEVICE_ID_INTEL_KBP_H_LWB_SMBUS
Ack
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 3365: #define PCI_DEVICE_ID_INTEL_C620_P2SB 0xa1a0
duplicates PCI_DEVICE_ID_INTEL_LWB_P2SB
Ack