Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32122 )
Change subject: src: Add missing include 'console.h' ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/#/c/32122/6/src/soc/mediatek/mt8173/rtc.c File src/soc/mediatek/mt8173/rtc.c:
https://review.coreboot.org/#/c/32122/6/src/soc/mediatek/mt8173/rtc.c@17 PS6, Line 17: #include <console/console.h> Do you really need it here? The only things that are printed here are done so using rtc_info() wrapper. This wrapper is defined in soc/rtc_common.h where console/console.h is already included. Or have I missed something?
https://review.coreboot.org/#/c/32122/6/src/soc/mediatek/mt8183/rtc.c File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/#/c/32122/6/src/soc/mediatek/mt8183/rtc.c@17 PS6, Line 17: #include <console/console.h> Same here
https://review.coreboot.org/#/c/32122/6/src/southbridge/amd/agesa/hudson/smb... File src/southbridge/amd/agesa/hudson/smbus.c:
https://review.coreboot.org/#/c/32122/6/src/southbridge/amd/agesa/hudson/smb... PS6, Line 20: #include <console/console.h> I don't see this necessary here. All the printk() calls here are commented out.
https://review.coreboot.org/#/c/32122/6/src/southbridge/amd/pi/hudson/smbus.... File src/southbridge/amd/pi/hudson/smbus.c:
https://review.coreboot.org/#/c/32122/6/src/southbridge/amd/pi/hudson/smbus.... PS6, Line 20: #include <console/console.h> printk()-calls commented out here as well so this should not be needed?
https://review.coreboot.org/#/c/32122/6/src/southbridge/amd/sb800/smbus.c File src/southbridge/amd/sb800/smbus.c:
https://review.coreboot.org/#/c/32122/6/src/southbridge/amd/sb800/smbus.c@20 PS6, Line 20: #include <console/console.h> here, too