Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41586 )
Change subject: drivers/vpd: add support for VPD_RW_OR_RO
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41586/2/src/drivers/vpd/vpd.c
File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/41586/2/src/drivers/vpd/vpd.c@208
PS2, Line 208: return NULL;
Please add {} around this branch too. […]
Done
https://review.coreboot.org/c/coreboot/+/41586/2/src/drivers/vpd/vpd.c@223
PS2, Line 223: return NULL;
Ditto.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I960688d1f6ab199768107ab73b8a7400a3fdf473
Gerrit-Change-Number: 41586
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 17:18:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment