[coreboot-gerrit] Change in coreboot[master]: soc/intel/broadwell/pcie.c: Add some null checks

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45715 )

Change subject: soc/intel/broadwell/pcie.c: Add some null checks
......................................................................

Patch Set 3: Code-Review+2
> Patch Set 3:
> > Patch Set 3: Code-Review+1
> >
> > these checks are useful, but checking that index isn't <0 or >= MAX_NUM_ROOT_PORTS would probably be a good idea too
>
> Yeah, I think these limits are guaranteed by the loops themselves though. I'll see how this would look like once deduplicated.

Being a static function, it's also easier to audit the inputs passed to it. Right now, I can see it's only called from for loops looping from 0 to rpc.num_ports (assuming that's initialized already by this point).