Attention is currently required from: Emilie Roberts, Paul Menzel.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81089?usp=email )
Change subject: drivers/intel/pmc_mux/conn: Copy ACPI _PLD property from USB port to mux ......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81089/comment/79b376d9_48da0c2c : PS5, Line 9: Copy ACPI _PLD values from USB ports to corresponding USB muxes.
Please elaborate by describing the problem.
@hadrosaur@google.com Hey Emilie, could you give more context to how we are planning to use this for?
https://review.coreboot.org/c/coreboot/+/81089/comment/d3e859eb_918ca91f : PS5, Line 12: TEST=emerge-${BOARD} coreboot
Did Emilie test more?
I believe she checked ACPI tables correctly generated on dut.
Patchset:
PS5:
I just tested this on mithrax, there seems to be an ordering error. […]
I just checked on mithrax and it appears to be that port0 is on the right side and port1 is on the left side. I used the following to check the location. ``` grep "" /sys/class/typec/port0/physical_location/* grep "" /sys/class/typec/port1/physical_location/* ```
Does connecting a device to the left port create `/sys/class/typec/port0-partner`? If that is the case, I think we might have had incorrect _PLD values in the first place which would be a separate issue.
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/81089/comment/a12c34e8_8aaec741 : PS5, Line 155: // Copy _PLD from USB ports
The rest of the file uses C89 comment style.
Done