[coreboot-gerrit] Change in coreboot[master]: soc/intel/fsp_broadwell_de: move get_busno1() into vtd.c

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35585 )

Change subject: soc/intel/fsp_broadwell_de: move get_busno1() into vtd.c
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35585/1/src/soc/intel/fsp_broadwell... 
File src/soc/intel/fsp_broadwell_de/vtd.c:

https://review.coreboot.org/c/coreboot/+/35585/1/src/soc/intel/fsp_broadwell... 
PS1, Line 52: int8_t get_busno1(void)
            : {
            : 	uint32_t reg32;
            : 
            : 	/* Figure out what bus number is assigned for CPUBUSNO(1) */
            : 	reg32 = pci_mmio_read_config32(VTD_PCI_DEV, VTD_CPUBUSNO);
            : 	return ((reg32 >> VTD_CPUBUSNO_BUS1_SHIFT) & VTD_CPUBUSNO_BUS1_MASK);
            : }
> Is there a reason that you have added it in vtd.c instead of in ubox. […]

because we are reading this register from VTD device not UBOX device