Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42413 )
Change subject: cpu/intel/206ax: Fix get_cores_per_package
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42413/1/src/cpu/intel/model_206ax/a...
File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/42413/1/src/cpu/intel/model_206ax/a...
PS1, Line 15: get_cores_per_package
probably worth renaming this to get_threads_per_package or get_logical_cores_per_package
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42413
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib32c2d40408cfa42ca43ab42ed661c168e579ada
Gerrit-Change-Number: 42413
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jun 2020 07:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment