Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40563 )
Change subject: soc/intel/common: Trigger recovery mode for CSE Lite SKU run time errors
......................................................................
Patch Set 9:
(1 comment)
Patch Set 8:
Patch Set 8:
I guess I'm just confused whether we're calling this the 'CSE Custom SKU' or 'CSE Lite SKU
I think we should make it consistent and call it "CSE Lite SKU".
Done.
https://review.coreboot.org/c/coreboot/+/40563/8/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/custom_bp.c:
https://review.coreboot.org/c/coreboot/+/40563/8/src/soc/intel/common/block/...
PS8, Line 151: do_global_reset();
Please add brackets around the else branch too. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40563
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7744fc4fd0e41804d9b45079bf706b300220c62
Gerrit-Change-Number: 40563
Gerrit-PatchSet: 9
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 May 2020 20:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment