Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40425 )
Change subject: mb/google/volteer: Add support for USB Type-C ports ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/acpi/usbc.asl:
PS1:
Couple of things. +1 to Caveh, this pretty much has to be generated at runtime. […]
BTW, for the specific case of Volteer: both the parade part and burnside bridge have similar expected behaviour: - SBU lines lane reversal handled by the retimer. - HS (i.e SSTx/SSRx) lines lane reversal handled by AP (TCSS)
So it doesn't look like we will need runtime tweaking of those two properties for Volteer (that's not to say this will be the case for other retimers / board configurations)
https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee... PS1, Line 24: "normal" Is this the terminology being used by the kernel code which will be upstreamed?
https://github.com/krohei/linux/commit/c9dbafc424ad075aa424037440af01d60e92a... suggests enums/ints are being used.