Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44158 )
Change subject: mb/google/zork: Use dev_nested_path for dmic gpio update ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG@9 PS1, Line 9: Created Please use present tense.
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG@9 PS1, Line 9: rewrote Ditto.
https://review.coreboot.org/c/coreboot/+/44158/1//COMMIT_MSG@10 PS1, Line 10: new find_dev_nested_path function “new” to me implies, it’s added in this commit. But it’s already there.
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/ramstage_common.c:
https://review.coreboot.org/c/coreboot/+/44158/1/src/mainboard/google/zork/v... PS1, Line 92: __func__); This should fit in 96 characters.