Attention is currently required from: Chen-Tsung Hsieh, jitao shi, Shaoming Chen.
Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 )
Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51432/comment/64054281_d99fcb39
PS2, Line 207: 10
For Jacuzzi projects, yes you keep it as 12. […]
But for Kukui projects (NOT using anx7625, NOT enable MIPI_DSI_MODE_EOT_PACKET),
Do we really expect to change it from 12 to 10?
A: Kukui projects(NOT using anx7625) is enable EOTP, due to MIPI_DSI_MODE_EOT_PACKET actually means disable EoTp before this CL.
https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
On the other hand, I checked the driver in kernel.
You use 18 or 12 for the delta according to MIPI_DSI_MODE_VIDEO_BURST.
Without checking MIPI_DSI_MODE_EOT_PACKET.
A: There is patch for kernel to fix EoTp flag's delta data.
https://patchwork.kernel.org/project/linux-mediatek/patch/20210201033603.126...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c
Gerrit-Change-Number: 51432
Gerrit-PatchSet: 5
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-CC: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-CC: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Attention: jitao shi
jitao.shi@mediatek.com
Gerrit-Attention: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 07:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@google.com
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@chromium.org
Comment-In-Reply-To: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-MessageType: comment