Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/35715 )
Change subject: gma g45: Read CDClk and calculate dot-clock limits ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/35715/4/common/g45/hw-gfx-gma-pow... File common/g45/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/35715/4/common/g45/hw-gfx-gma-pow... PS4, Line 40: : GM45_2667 : constant Div_Array := (12, 8, others => 1); : GM45_3200 : constant Div_Array := (14, 10, others => 1); : GM45_4000 : constant Div_Array := (18, 12, others => 1); : GM45_5333 : constant Div_Array := (24, 16, others => 1); This got me worried that something was wrong in cdclock calculation in gma.c in coreboot. Nice way of unifying computing cdclk