Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44782 )
Change subject: fw_config: Add caching to successfully probed fields ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I like that this solves it in a generic way, having all the probed options in DMI will be useful for debug.
You might consider having arch/x86/smbios.c:smbios_write_type11() call an fw_config function to add the strings rather than needing each mainboard to add a handler.
I thought about that, but I disliked the direct coupling between fw_config & smbios. How about a new file src/vendorcode/google/chromeos/smbios.c with the implementation there?
If we do that, we actually may want to add something in vendorcode to set up the x86 mainboard callbacks (acpi_inject_dsdt, now get_smbios_strings) as well
It might be a problem for people using a build without CONFIG_CHROMEOS. The current function walks all devices so cros_ec could register a handler too, but that makes a bit of a circle where fw_config calls cros_ec to get the value and cros_ec calls fw_config to print the strings. maybe just having it in the baseboard like you do now is fine...