[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8183: improve the DRAMC runtime config flow

[Duan huayang (Code Review)]

Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38490 )

Change subject: soc/mediatek/mt8183: improve the DRAMC runtime config flow
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/38490/1/src/soc/mediatek/mt8183/dra... 
File src/soc/mediatek/mt8183/dramc_pi_basic_api.c:

https://review.coreboot.org/c/coreboot/+/38490/1/src/soc/mediatek/mt8183/dra... 
PS1, Line 290: 			(0x7 << 28) | (0x7 << 24), (0x1 << 28) | (0x0 << 24));
> I meant […]

Done

https://review.coreboot.org/c/coreboot/+/38490/1/src/soc/mediatek/mt8183/dra... 
PS1, Line 326: 		(0x7 << 22) | (0x3 << 14) | (0x1 << 19) | (0x1 << 21));
> I meant […]

Done

https://review.coreboot.org/c/coreboot/+/38490/1/src/soc/mediatek/mt8183/dra... 
PS1, Line 381: 	setbits32(&ch[chn].ao.dummy_rd, 0x1 << 25 | 0x1 << 20);
> Could you move all the bug fixes to a separate CL? It's hard to tell bug fixes from improvement.

Done