Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38222 )
Change subject: soc/amd/stoneyridge: move to using smbus_host.h definitions
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38222/8/src/soc/amd/stoneyridge/smb...
File src/soc/amd/stoneyridge/smbus.c:
https://review.coreboot.org/c/coreboot/+/38222/8/src/soc/amd/stoneyridge/smb...
PS8, Line 92: int do_smbus_recv_byte(uintptr_t mmio, u8 device)
The way recv_byte() and send_byte() are being used to read SPD eeprom is about twice as fast as usin […]
Both Intel and AMD SMBus controllers use Synopsys IP cores, so it's not surprising that they are so similar.
w.r.t. raminit code, a read_spd() abstraction would be better I guess.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic912b91daf79ecd2c276a383edcda563891cf643
Gerrit-Change-Number: 38222
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 21:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment