Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Angel Pons, Fred Reitberger, Patrick Rudolph, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55067 )
Change subject: arch/x86: Add a common romstage entry ......................................................................
Patch Set 9:
(5 comments)
File src/include/romstage_common.h:
https://review.coreboot.org/c/coreboot/+/55067/comment/6ba79124_8159bc57 PS5, Line 8: __
nit: remove the leading underscores
Done
File src/include/romstage_common.h:
https://review.coreboot.org/c/coreboot/+/55067/comment/59331aed_0b8debde PS3, Line 6: romstage_main
Since this is only for x86 for now, can you add this prottype to arch/romstage.h?
Used by other platforms in the next CL.
File src/soc/amd/picasso/romstage.c:
https://review.coreboot.org/c/coreboot/+/55067/comment/60746af9_33bedeaf PS5, Line 3: #include <acpi/acpi.h> : #include <amdblocks/memmap.h> : #include <amdblocks/pmlib.h> : #include <arch/cpu.h> : #include <commonlib/helpers.h> : #include <console/console.h> : #include <fsp/api.h> : #include <program_loading.h> : #include <timestamp.h> : #include <types.h>
Looks like these includes are sorted alphabetically. […]
Done
https://review.coreboot.org/c/coreboot/+/55067/comment/f4c736cf_dcfecc1d PS5, Line 17: timestamp_add_now(TS_START_ROMSTAGE);
This needs to be removed
Done
File src/soc/example/min86/romstage.c:
https://review.coreboot.org/c/coreboot/+/55067/comment/1157b938_33d0a6a7 PS5, Line 4: #include <arch/cpu.h>
No longer needed
Done