Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33439 )
Change subject: mb/asrock/h110m: Unselect incorrect Kconfig symbol
......................................................................
Patch Set 1:
Unfortunately, the early console doesn`t work without SUPERIO_NUVOTON_NCT6776_COM_A symbol.
I'd suggest adding the proper SUPERIO_NUVOTON_NCT6791_COM_A symbol to both the NCT6791 Kconfig (with guards like the follow-up patch to this one) and the early init code where it sets both uart pinmux bits to the right setting (and not only one like in the currently used code path).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f3fde161844f919b070f2b6ce7e106411439a9a
Gerrit-Change-Number: 33439
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov
m.poliakov@yahoo.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Jun 2019 15:40:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment