build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 24:
(5 comments)
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... PS24, Line 23: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... PS24, Line 78: { that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... PS24, Line 170: InitPost->MemConfig.PlatformMemoryConfiguration = (PSO_ENTRY *) MemoryTable_XM_E; line over 96 characters
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/bootblock.c:
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... PS24, Line 24: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/30987/24/src/mainboard/asus/a88xm-e... PS24, Line 236: { that open brace { should be on the previous line