Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40662 )
Change subject: documentation: Add documentation ideas for season of docs ......................................................................
Patch Set 8: Code-Review+1
(21 comments)
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... File Documentation/contributing/documentation_ideas.md:
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 1: # Documentation Ideas
I would avoid camel case for the headlines.
I would not.
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 3: to improve
for improving
I guess both works.
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 11: entry
proposal?
As this is a list of ideas, IMHO it can be entries.
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 16: Restructure
Restructuring
nope
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 18: structure
I would write a "to" before that. Sounds better IMO.
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 22: to restructure the documentation is to split it up such : that we divide the group of users into:
for the restructuring is to split the documentation up into sections targeting different groups of p […]
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 27: coreboot
it
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 32: of : coreboot
I would remove that, since it was mentioned right before.
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 37: the developers section
it
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 59: s
singular
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 61: setting coreboot up
setting up coreboot
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 62: E
e
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 64: needs an update/extensions
needs improvements on the usability
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 64: G
g
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 67: technique
technique_s_
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 84: support
let me correct myself.. […]
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 107: Tinanocore
TianoCore
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 107: b
B
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 108: Grub
GRUB
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 118: provide
provide_s_
Ack
https://review.coreboot.org/c/coreboot/+/40662/8/Documentation/contributing/... PS8, Line 134: don't
don't_s_
Ack