Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38593 )
Change subject: sc7180: GPIO: Add I2S configuration for sc7180
......................................................................
Patch Set 10:
(1 comment)
LGTM after style issues.
https://review.coreboot.org/c/coreboot/+/38593/10/src/mainboard/google/trogd...
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38593/10/src/mainboard/google/trogd...
PS10, Line 38: GPIO_PULL_UP,GPIO_8MA, GPIO_OUTPUT);
space required after that ',' (ctx:VxV)
Please fix these style errors
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I681aa6d0d57671b0fd9b7bc88de6f2cc202a7af0
Gerrit-Change-Number: 38593
Gerrit-PatchSet: 10
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Mar 2020 23:08:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment