[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Convert DDR4 MHz to MT/s correctly

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )

Change subject: soc/amd/picasso: Convert DDR4 MHz to MT/s correctly
......................................................................

Patch Set 4: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c 
File src/soc/amd/picasso/dmi.c:

https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c@3... 
PS4, Line 33: #define DDR4_MIN DDR4_1600
            : #define DDR4_MAX DDR4_3200
            : #
Can you put these in the enum, e.g.
    DDR4_UNSPECIFIED,
    DDR4_1600,
    DDR4_MIN = DDR4_1600,
...
    DDR4_3200,
    DDR4_MAX = DDR4_3200
That way it's harder for them to get out of sync.