Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38154 )
Change subject: soc/intel/{apl,cnl,icl,skl,tgl}: Clean up SA ASL code
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38154/4/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/38154/4/src/soc/intel/cannonlake/ac...
PS4, Line 43: 31:15
Thanks for the pointer.
here is my findings
1. In coreboot we are always programming MCHBAR as 32bit value
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/block/...
https://github.com/coreboot/coreboot/blob/50ee91c17c386b47e8d3c02bbdcc9e1324...
MCHBAR offset = 48 value = fed10000
2. Dumping the same from common northbridge.asl shows the same 32bit value using APRT
APRT (_SB.PCI0.GMHB ())
0x00000000FED10000
i guess the issue could be if MCHBAR is more than 32 bit value then all above assumptions will fail.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38154
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id74269ec5a96b087562ccdf2141233db5585ae59
Gerrit-Change-Number: 38154
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jan 2020 06:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment