Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31534 )
Change subject: soc/intel/cannonlake: Set FSP-S Enable8254ClockGating using clock_gate_8254 devicetree parameter
......................................................................
Patch Set 2:
(1 comment)
Enable8254ClockGatingOnS3 is only applicable when Enable8254ClockGating is disabled. FSP will do the
8254 CGE programming on S3 resume when Enable8254ClockGatingOnS3 is enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31534
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id346173ac7ae5246de0b38b9dd23be7b72e70f1e
Gerrit-Change-Number: 31534
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 21 Feb 2019 00:34:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment