Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )
Change subject: acpi: Add support for reporting CrashLog in BERT table ......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10: hm, ok, since you're putting some raw data into a bert entry, we need to support raw_data_length but also raw_data_offset, since linux will be unhappy if that one is zero and the other one non-zero. still trying to figure out the details though. i don't really need to rush in the patch/hack reverting the raw_data_length writes that made things work again for me, so finding a proper solution that works for all case would be my preferred approach. mostly needed that partial revert to test the other parts of my patch series. on the acpi bert ssdt generation code in acpi/acpi.c: i'd like to move the code added here https://review.coreboot.org/c/coreboot/+/54149/2/src/soc/amd/picasso/agesa_a... to the common acpi code and rework how the code added in this patch interacts with the bert ssdt generation to avoid duplicating functionality and to also avoid to have to call into soc code when the common code already has the corresponding functionality