Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46042 )
Change subject: vendorcode/google/chromeos: Add camera info ......................................................................
Patch Set 1:
I guess ideally it would make sense to allow building this without CONFIG_CHROMEOS, although I wonder if in practice that would ever happen? Does anyone ever attempt to build coreboot for a Chromebook without CONFIG_CHROMEOS?
Not just Coreboot, people who try to build uboot may still want to boot Chrome OS kernel using same config (device tree).
My preference would be something like drivers/camera/chromeos-eeprom.c, but I don't have much experience with coreboot, so please do whatever appropriate. :)
Then I'd vote for drivers/camera/chrome_eeprom.c
Maybe not calling it "chromeos" given we're actually dealing with "camera on chromebooks" (e.g., hw instead of sw).