Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40598 )
Change subject: mb/google/volteer/malefor: Enable touch screen
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40598/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40598/4/src/mainboard/google/voltee...
PS4, Line 17: register "generic.has_power_resource" = "1"
actually, do we also need […]
from what I understand this is to disable the GPIO resources from _CRS, which should be used in case reset and enable GPIOs are not provided, which isn't the case here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I236ac56dd0a1817092151bae93e699115ba88e4c
Gerrit-Change-Number: 40598
Gerrit-PatchSet: 4
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-CC: Yan Liu
yan.liu@bitland.corp-partner.google.com
Gerrit-Comment-Date: Wed, 29 Apr 2020 21:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment