Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31525 )
Change subject: mb/ocp/monolake: add TPM and IPMI support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31525/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31525/1//COMMIT_MSG@11
PS1, Line 11: - enabled TPM1 + added entry in devicetree
Maybe, remove the indentation, and use imperative mood:
- enable TPM1 + add entry in devicetree
(also below)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31525
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f9fb17b9f1349272080e032991fe45a443a9d84
Gerrit-Change-Number: 31525
Gerrit-PatchSet: 1
Gerrit-Owner: Łukasz Siudut
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: Łukasz Siudut
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 Feb 2019 17:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment