[coreboot-gerrit] Change in coreboot[master]: src/mb/intel/coffeelake_rvp: Add mainboard for CML-S RVP8

[Gaggery Tsai (Code Review)]

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36685 )

Change subject: src/mb/intel/coffeelake_rvp: Add mainboard for CML-S RVP8
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36685/13/src/mainboard/intel/coffee... 
File src/mainboard/intel/coffeelake_rvp/variants/cml_s/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36685/13/src/mainboard/intel/coffee... 
PS13, Line 89: 	register "PcieRpEnable[4]" = "1"
> Sorry if I wasn't clear. […]

Yes, the setting of x4 or x1 is done with FIT tool. AFAIK, it's not a harm to enable other root ports since this is RVP, those ports are connected to a PCIe slot as an alternative. Users could use FIT to set it back to x1, so this setting in DT provides more flexibility.