1 Jul
2019
1 Jul
'19
6:50 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33859 )
Change subject: Kconfig: Enable RAMPAYLOAD for x86 ......................................................................
Patch Set 3:
Well my criticism was mostly about the process, not the commit context.
I would have preferred to see the fundamental change of RAMPAYLOAD to be submitted, with documentation, after the (pending) release. The concept is now submitted scattered over period of several months, and yet there is not a single 'select HAVE_RAMPAYLOAD' line.
So currently in upstream tree none of this concept is even build-tested? Is there published/pending work in gerrit that validates these changes on some level at least?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40308bbf970a0dbe5f7e2086ed8a7a70c2a3a32c
Gerrit-Change-Number: 33859
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jul 2019 04:50:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment