Attention is currently required from: Eran Mitrani, Eric Lai, Eric Lai, Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78180?usp=email )
Change subject: mb/google/rex/var/rex0: update dptf thermal settings to start fan earlier ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78180/comment/fc9c1c0c_1015ca46 : PS2, Line 7: update dptf thermal settings
Maybe more specific: […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/78180/comment/70dfa7f2_19e12f5c : PS2, Line 9: During internal testing observed
Maybe: Internal testing showed, …
Done
https://review.coreboot.org/c/coreboot/+/78180/comment/c9fcbb35_ae333eb2 : PS2, Line 10: While this even fan does not start : to control the temperature.
Maybe: In this situation, the fan does not even start to lower the temperature.
Done
https://review.coreboot.org/c/coreboot/+/78180/comment/eaef3bbe_38c99767 : PS2, Line 12: high
too high
Acknowledged
https://review.coreboot.org/c/coreboot/+/78180/comment/f2b78663_8561a0a7 : PS2, Line 13: With updated new settings
Please document, where the new settings came from. […]
Done
https://review.coreboot.org/c/coreboot/+/78180/comment/416c6a5a_59fc41ab : PS2, Line 13: start fan early for TSR0 and TSR1 : sensors to prevent high CPU temperature
Maybe: … the fan starts early for TSR0 and TSR1 so the temperature stays below X °C.
Done