Martin Roth has posted comments on this change. ( https://review.coreboot.org/19604 )
Change subject: mainboard/intel/glkrvp: Add support for GLKRVP
......................................................................
Patch Set 34:
(1 comment)
https://review.coreboot.org/#/c/19604/34/src/mainboard/intel/glkrvp/Kconfig
File src/mainboard/intel/glkrvp/Kconfig:
PS34, Line 41: config DRIVERS_I2C_GENERIC
: default y
This needs to be enabled with a 'select' statement or it adds a dependency on this mainboard that the other mainboards fail to meet.
--
To view, visit
https://review.coreboot.org/19604
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab688aca6a4f5c5e32801215ba3a1a440e50fbef
Gerrit-PatchSet: 34
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Brenton Dong
brenton.m.dong@intel.com
Gerrit-Reviewer: Cole Nelson
colex.nelson@intel.com
Gerrit-Reviewer: Han Lim Ng
nhlhanlim93@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes