Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32297 )
Change subject: soc/intel/cannonlake: Enable PlatformDebugConsent by Kconfig ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32297/7/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/32297/7/src/soc/intel/cannonlake/Kconfig@305 PS7, Line 305: default 3 if SOC_INTEL_DEBUG_CONSENT
The reason i didn't put CHROMEOS as a dependency here is i think USB DBC is more common for develope […]
SG. Can you add a comment here that the default debug interface is DBC?
https://review.coreboot.org/#/c/32297/7/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32297/7/src/soc/intel/cannonlake/romstage/fs... PS7, Line 116: m_cfg->PlatformDebugConsent = \
if i don't do this, it will be over 80 char
I don't think you need a '' to put CONFIG_SOC_INTEL_CANNONLAKE_DEBUG_CONSENT on the next line.